Create install-mdbook.sh and lock to the current versions used in the CI #2626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I move the install script into some subfolder to have the root more clean? I cannot find a suitable existing folder for this. I could create a scripts/ folder but this would for now only contain this file |
I don't think this is necessary! |
michael-kerscher
added a commit
to michael-kerscher/comprehensive-rust
that referenced
this pull request
Feb 7, 2025
… CI (google#2626) Move mdbook installation into a script and use exact versions from the CI. Update README.md to instruct developers to use the same versions as the CI to sync both environments. This is related to google#2620 and it fixes google#2588
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move mdbook installation into a script and use exact versions from the CI.
Update README.md to instruct developers to use the same versions as the CI to sync both environments.
This is related to #2620 and it fixes #2588